-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3657 modular explore #4407
3657 modular explore #4407
Conversation
Update the description for the Data Explorer
Note the FIXME that this is working from the file page but not the dataset page.
Here we are differentiating between popups for TwoRavens ("explore") and popups for external tools ("externalTool").
We don't want to show explore tools for images and such until there is a use case, at which time we can add a column to the externaltool table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest that Two Ravens be treated as any other external tool. This would help to simplify the file download-button-fragment. Also, the explore on the FileDownloadServiceBean should be called from the FileDownloadHelper in order for the validator to work. This will have to be done after merging #4393.
@sekmiller thanks. As we've been discussing, there's a good chance we'll close this pull request and put the new combo pull request at #4413 through QA instead. |
Conflicts (just imports): src/main/java/edu/harvard/iq/dataverse/GuestbookResponseServiceBean.java
We haven't shipped a release with the externaltool table yet so people shouldn't have any existing data.
Changes Unknown when pulling 5826fea on 3657-modular-explore into ** on develop**. |
Changes Unknown when pulling 5dee126 on 3657-modular-explore into ** on develop**. |
Closing in favor of pull request #4426. |
original PR for #3657 Modular Explore, superseded by pull request #4426